Multi-selection: Add new FAB to the tab switcher #5467

0nko · 2025-01-14T13:09:09Z

Task/Issue URL: https://app.asana.com/0/72649045549333/1207969573539951

Description

This PR adds the FAB to the tab switcher. It is hidden under a feature flag, which must be enabled first.

This PR demonstrates the 2 states of the FAB that will be used later in the multi-selection -- "New Tab" & "Close Tabs". Clicking the button will not actually change this in the actual implementation.

Steps to test this PR

0nko · 2025-01-14T13:09:30Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Multi-selection: Add new FAB to the tab switcher #5467 👈 (View in Graphite)
Multi-selection: Tab switcher #5464 : 9 other dependent PRs (#5588 , #5623 , #5710 and 6 others)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

mikescamell

Looks good, just need confirmation on the testing step about whether the FAB should hide or not 👍

mikescamell · 2025-03-05T13:41:32Z

app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherActivity.kt

+    private fun updateFabType(fabType: TabSwitcherViewModel.ViewState.FabType) {
+        when (fabType) {
+            TabSwitcherViewModel.ViewState.FabType.NEW_TAB -> {
+                tabsFab.icon = AppCompatResources.getDrawable(this, com.duckduckgo.mobile.android.R.drawable.ic_add_24)


🔍 Add an import for the R class

mikescamell · 2025-03-05T13:44:18Z

app/src/main/res/layout/activity_tab_switcher.xml


-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
+<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"


❓ If we're switching to a CoordinatorLayout, do we need the LinearLayout anymore?

I think app:layout_behavior="@string/appbar_scrolling_view_behavior" on the RecyclerView should take care of offsetting the RecyclerView from the Toolbar, from what I remember 😅

mikescamell · 2025-03-05T13:46:56Z

common/common-ui/src/main/res/values/widgets.xml

        <item name="android:paddingStart">@dimen/keyline_2</item>
    </style>

+    <style name="Widget.DuckDuckGo.ExtensibleFloatingActionButton" parent="Widget.MaterialComponents.ExtendedFloatingActionButton">


❓ Are we calling it "Extensible" in our design system rather than "Extended"? 😁

mikescamell

Looks good, just need confirmation on the testing step about whether the FAB should hide or not 👍

0nko · 2025-03-06T20:07:31Z

Thanks for the review! 🙇‍♂️

Task/Issue URL: https://app.asana.com/0/72649045549333/1207969573539951 ### Description This PR adds the FAB to the tab switcher. It is hidden under a feature flag, which must be enabled first. This PR demonstrates the 2 states of the FAB that will be used later in the multi-selection -- "New Tab" & "Close Tabs". Clicking the button will not actually change this in the actual implementation. ### Steps to test this PR - [x] Go to Settings -> Feature Flag Inventory - [x] Type "multi" - [x] Enable the feature flag - [x] Leave the tab switcher activity if there already - [x] Open the tab switcher activity - [x] Notice the FAB is displayed - [x] Verify the `+` icon is shown and the title is "New Tab" - [x] Scroll up & down - [x] Verify that the FAB shrink while scrolling down - [x] Tap on the FAB - [x] Verify the icon changes to `x` and title says "Close Tabs"

0nko mentioned this pull request Jan 14, 2025

Multi-selection: Tab switcher #5464

Merged

0nko changed the title ~~Add new FAB styles~~ Add new FAB to the tab switcher Jan 14, 2025

0nko marked this pull request as ready for review January 14, 2025 13:16

0nko requested review from malmstein and nalcalag as code owners January 14, 2025 13:16

0nko changed the title ~~Add new FAB to the tab switcher~~ Multi-selection: Add new FAB to the tab switcher Jan 14, 2025

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 0b382b2 to 8492b52 Compare January 15, 2025 17:28

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 67aa25e to c303d4b Compare January 15, 2025 17:28

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 8492b52 to c4c3cf8 Compare January 27, 2025 10:12

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 5916903 to 79bc6aa Compare January 27, 2025 10:12

0nko force-pushed the feature/ondrej/tab-multi-selection branch from c4c3cf8 to c3270a9 Compare January 27, 2025 10:19

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 79bc6aa to 2acd9ec Compare January 27, 2025 10:19

0nko force-pushed the feature/ondrej/tab-multi-selection branch from c3270a9 to e6e2148 Compare January 31, 2025 15:26

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from d85d6d1 to 6c267e1 Compare January 31, 2025 15:27

0nko force-pushed the feature/ondrej/tab-multi-selection branch from e6e2148 to ff15dd9 Compare February 3, 2025 20:20

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 6c267e1 to ae833dd Compare February 3, 2025 20:20

This was referenced Feb 3, 2025

Multi-selection: Dynamic menu #5588

Merged

Multi-selection: Selection mode #5623

Merged

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from ae833dd to 88714c8 Compare February 13, 2025 10:54

0nko force-pushed the feature/ondrej/tab-multi-selection branch from ff15dd9 to 02fb482 Compare February 13, 2025 10:54

0nko requested review from mikescamell and removed request for malmstein and nalcalag February 13, 2025 10:58

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 02fb482 to b238763 Compare February 14, 2025 09:42

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch 2 times, most recently from 3987163 to 195a3f0 Compare February 14, 2025 14:01

0nko force-pushed the feature/ondrej/tab-multi-selection branch from eab74f4 to 3d62cf6 Compare February 14, 2025 14:01

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 3d62cf6 to 01126c4 Compare February 27, 2025 17:15

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 195a3f0 to 057e4d2 Compare February 27, 2025 17:15

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 25ddd72 to c39f956 Compare March 5, 2025 10:01

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 3536b27 to 4b5cef8 Compare March 5, 2025 10:02

mikescamell self-assigned this Mar 5, 2025

mikescamell approved these changes Mar 5, 2025

View reviewed changes

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from c39f956 to 66bb476 Compare March 6, 2025 14:12

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 4b5cef8 to 32bdd14 Compare March 6, 2025 14:12

0nko force-pushed the feature/ondrej/tab-multi-selection branch from 32bdd14 to cf6b2b2 Compare March 10, 2025 10:07

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 7e86453 to 8b1c367 Compare March 10, 2025 10:07

0nko added 11 commits March 10, 2025 15:49

Add new FAB styles

09661cd

Add a FAB to the tab switcher

e7a292b

Shrink the FAB instead of hiding it

d1ed5c1

Shrink the FAB on scroll down, extend on up

1cc3e79

Move the FAB styles to the theme

9cf39d0

Remove unused resource

46855f2

Simplify the activity layout

65f8ad6

Import resource package

b4b7f44

Rename the Fab style

b8ce965

Use verb in function name

cb9e146

Add padding for FAB at the bottom

f237d70

0nko force-pushed the feature/ondrej/tab-multi-selection branch from cf6b2b2 to d7318f0 Compare March 10, 2025 14:49

0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 8b1c367 to f237d70 Compare March 10, 2025 14:49

0nko merged commit 096932e into feature/ondrej/tab-multi-selection Mar 10, 2025
4 of 9 checks passed

0nko deleted the feature/ondrej/tab-multi-selection-fab branch March 10, 2025 17:35

This was referenced Mar 18, 2025

Multi-selection: Pixels #5788

Merged

Multi-selection: Tests #5799

Merged

This was referenced Mar 31, 2025

Multi-selection: Translations #5840

Merged

Multi-selection: Ship review change requests #5841

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multi-selection: Add new FAB to the tab switcher #5467

Multi-selection: Add new FAB to the tab switcher #5467

0nko commented Jan 14, 2025 •

edited by mikescamell

Loading

Uh oh!

0nko commented Jan 14, 2025 •

edited

Loading

Uh oh!

mikescamell left a comment

Uh oh!

mikescamell Mar 5, 2025

Uh oh!

mikescamell Mar 5, 2025

Uh oh!

0nko Mar 6, 2025

Uh oh!

mikescamell Mar 5, 2025

Uh oh!

mikescamell left a comment

Uh oh!

0nko commented Mar 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Multi-selection: Add new FAB to the tab switcher #5467

Multi-selection: Add new FAB to the tab switcher #5467

Conversation

0nko commented Jan 14, 2025 • edited by mikescamell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

Uh oh!

0nko commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikescamell left a comment

Choose a reason for hiding this comment

Uh oh!

mikescamell Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

mikescamell Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

0nko Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

mikescamell Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

mikescamell left a comment

Choose a reason for hiding this comment

Uh oh!

0nko commented Mar 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0nko commented Jan 14, 2025 •

edited by mikescamell

Loading

0nko commented Jan 14, 2025 •

edited

Loading