-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Multi-selection: Dynamic menu #5588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0nko
merged 12 commits into
feature/ondrej/tab-multi-selection
from
feature/ondrej/tab-multi-selection-menu
Mar 13, 2025
Merged
Multi-selection: Dynamic menu #5588
0nko
merged 12 commits into
feature/ondrej/tab-multi-selection
from
feature/ondrej/tab-multi-selection-menu
Mar 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
ae833dd
to
88714c8
Compare
974409b
to
10a05be
Compare
10a05be
to
da7bac5
Compare
88714c8
to
3987163
Compare
da7bac5
to
ad27238
Compare
3987163
to
195a3f0
Compare
ad27238
to
e8eb5dd
Compare
057e4d2
to
ee6fd8b
Compare
e8eb5dd
to
c07b112
Compare
ee6fd8b
to
5fe520a
Compare
5a35ab9
to
8b10fc0
Compare
5fe520a
to
4a66f43
Compare
4a66f43
to
c322c3f
Compare
569d1c3
to
afbde89
Compare
25ddd72
to
c39f956
Compare
afbde89
to
5c0b727
Compare
c39f956
to
66bb476
Compare
e304fab
to
e2083c1
Compare
8b1c367
to
f237d70
Compare
e17f763
to
7724de9
Compare
Base automatically changed from
feature/ondrej/tab-multi-selection-fab
to
feature/ondrej/tab-multi-selection
March 10, 2025 17:35
7724de9
to
e83d72a
Compare
096932e
to
2d16741
Compare
b74f3a5
to
ba2b9fb
Compare
4a543ec
into
feature/ondrej/tab-multi-selection
3 of 9 checks passed
This was referenced Mar 18, 2025
Merged
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868655
Description
This PR adds a dynamic menu that updates its menu items based on the selection view state.
Screen_recording_20250204_094857.mp4
The selection functionality isn’t implemented yet, so tapping on the FAB simulates different states.
Figma screenshots for reference:
The menu options don't do anything except for
New Tab
andClose All
item.Steps to test this PR
tabManager / multiSelection
feature flag in the settings