Skip to content

Conversation

0nko
Copy link
Member

@0nko 0nko commented Feb 3, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868655

Description

This PR adds a dynamic menu that updates its menu items based on the selection view state.

Screen_recording_20250204_094857.mp4

The selection functionality isn’t implemented yet, so tapping on the FAB simulates different states.

  1. Selection mode with no tabs selected
  2. Selection Mode with 2 tabs selected
  3. Normal (non-selection mode)

Figma screenshots for reference:

1. 2. 3.
image image image

The menu options don't do anything except for New Tab and Close All item.

Steps to test this PR

  • Enable the tabManager / multiSelection feature flag in the settings
  • Open the tab manager
  • Notice the default menu reflects the Selection mode without selection (refer to 1.), with toolbar buttons disabled
  • Tap on the FAB
  • Notice the menu is updated to Selection mode with 2 tabs selected (refer to 2.), with toolbar buttons enabled and the number of tabs (2) reflected in the menu items
  • Tap on the FAB
  • Notice the menu is updated to Normal mode with the fire button and tab layout button (both working) and the correct menu (refer to 3.)

Copy link
Member Author

0nko commented Feb 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko marked this pull request as ready for review February 3, 2025 20:24
@0nko 0nko changed the title Add menus and resources Multi-selection: Dynamic menu Feb 3, 2025
@0nko 0nko mentioned this pull request Feb 10, 2025
46 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from ae833dd to 88714c8 Compare February 13, 2025 10:54
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from 974409b to 10a05be Compare February 13, 2025 10:54
@0nko 0nko requested a review from mikescamell February 13, 2025 10:58
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from 10a05be to da7bac5 Compare February 14, 2025 09:42
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 88714c8 to 3987163 Compare February 14, 2025 09:42
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from da7bac5 to ad27238 Compare February 14, 2025 14:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 3987163 to 195a3f0 Compare February 14, 2025 14:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from ad27238 to e8eb5dd Compare February 27, 2025 17:15
@0nko 0nko mentioned this pull request Feb 27, 2025
16 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 057e4d2 to ee6fd8b Compare February 28, 2025 17:43
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from e8eb5dd to c07b112 Compare February 28, 2025 17:43
@0nko 0nko mentioned this pull request Feb 28, 2025
32 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from ee6fd8b to 5fe520a Compare March 3, 2025 10:37
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch 2 times, most recently from 5a35ab9 to 8b10fc0 Compare March 3, 2025 20:28
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 5fe520a to 4a66f43 Compare March 3, 2025 20:28
@0nko 0nko mentioned this pull request Mar 3, 2025
41 tasks
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from 4a66f43 to c322c3f Compare March 3, 2025 20:39
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch 2 times, most recently from 569d1c3 to afbde89 Compare March 4, 2025 11:00
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch 2 times, most recently from 25ddd72 to c39f956 Compare March 5, 2025 10:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from afbde89 to 5c0b727 Compare March 5, 2025 10:02
@mikescamell mikescamell self-assigned this Mar 5, 2025
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch from c39f956 to 66bb476 Compare March 6, 2025 14:12
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch 2 times, most recently from e304fab to e2083c1 Compare March 10, 2025 10:07
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-fab branch 2 times, most recently from 8b1c367 to f237d70 Compare March 10, 2025 14:49
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from e17f763 to 7724de9 Compare March 10, 2025 14:49
Base automatically changed from feature/ondrej/tab-multi-selection-fab to feature/ondrej/tab-multi-selection March 10, 2025 17:35
@0nko 0nko requested review from malmstein and nalcalag as code owners March 10, 2025 17:35
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from 7724de9 to e83d72a Compare March 10, 2025 20:11
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from 096932e to 2d16741 Compare March 12, 2025 17:50
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-menu branch from b74f3a5 to ba2b9fb Compare March 12, 2025 17:50
@0nko 0nko merged commit 4a543ec into feature/ondrej/tab-multi-selection Mar 13, 2025
3 of 9 checks passed
@0nko 0nko deleted the feature/ondrej/tab-multi-selection-menu branch March 13, 2025 12:52
This was referenced Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants