-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Multi-selection: Selection mode #5623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0nko
merged 38 commits into
feature/ondrej/tab-multi-selection
from
feature/ondrej/tab-multi-selection-select-mode
Mar 13, 2025
Merged
Multi-selection: Selection mode #5623
0nko
merged 38 commits into
feature/ondrej/tab-multi-selection
from
feature/ondrej/tab-multi-selection-select-mode
Mar 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
974409b
to
10a05be
Compare
cedbb62
to
935cf93
Compare
05dd5c4
to
43b3325
Compare
da7bac5
to
ad27238
Compare
43b3325
to
bbcf57e
Compare
ad27238
to
e8eb5dd
Compare
33efb4e
to
ce975ab
Compare
ce975ab
to
c71a9c5
Compare
9c8d735
to
c006446
Compare
c07b112
to
5a35ab9
Compare
c006446
to
f0a0088
Compare
5a35ab9
to
8b10fc0
Compare
8b10fc0
to
569d1c3
Compare
f0a0088
to
fd772fb
Compare
569d1c3
to
afbde89
Compare
4a543ec
to
f013306
Compare
6661865
to
e359a18
Compare
be6af68
into
feature/ondrej/tab-multi-selection
4 of 5 checks passed
This was referenced Mar 18, 2025
Merged
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207969573539955
Description
This PR adds the tab selection UI and allows the tabs to be selected after triggering the selection mode. The selection mode can be cancelled by tapping anywhere outside a tab.
Some menu items and buttons are already functional, namely:
Non-functional items:
Steps to test this PR
Entering and leaving the selection mode
Selecting all tabs
Closing all tabs
Adding a new tab
List layout selection
Demo
Screen_recording_20250213_123419.mp4