-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-selection: Selection mode #5623
Open
0nko
wants to merge
13
commits into
feature/ondrej/tab-multi-selection-menu
Choose a base branch
from
feature/ondrej/tab-multi-selection-select-mode
base: feature/ondrej/tab-multi-selection-menu
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multi-selection: Selection mode #5623
0nko
wants to merge
13
commits into
feature/ondrej/tab-multi-selection-menu
from
feature/ondrej/tab-multi-selection-select-mode
+342
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
974409b
to
10a05be
Compare
cedbb62
to
935cf93
Compare
05dd5c4
to
43b3325
Compare
10a05be
to
da7bac5
Compare
da7bac5
to
ad27238
Compare
43b3325
to
bbcf57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207969573539955
Description
This PR adds the tab selection UI and allows the tabs to be selected after triggering the selection mode. The selection mode can be cancelled by tapping anywhere outside a tab.
Some menu items and buttons are already functional, namely:
Non-functional items:
Steps to test this PR
Entering and leaving the selection mode
Selecting all tabs
Closing all tabs
Adding a new tab
List layout selection
Demo
Screen_recording_20250213_123419.mp4