Repository navigation
ci: drop the obsolete deb-src edit and the privileged container - #141
Open
Bjordis Collaku (bjordiscollaku) wants to merge 2 commits into
Open
Bjordis Collaku (bjordiscollaku) wants to merge 2 commits into
Bjordis Collaku (bjordiscollaku) wants to merge 2 commits into
Conversation
Bjordis Collaku (bjordiscollaku)
force-pushed
the
ci/phase2-repo-and-suffix
branch
from
October 7, 2026 23:12
911a7b4 to
7ce0eb8
Compare
Bjordis Collaku (bjordiscollaku)
force-pushed
the
ci/phase4-debsrc-and-privileged
branch
from
October 7, 2026 23:12
4515291 to
a0eda06
Compare
The build enabled deb-src before resolving build dependencies. That was required while it resolved them by source package name, which reads the archive's Sources index. It has resolved them from the local tree since "apt-get build-dep -y ./", which reads the generated debian/control and needs no Sources index at all. The edit is also silent when it does nothing: it matches "Types: deb" in one DEB822 file by exact name, so a base image that formats its sources differently, or names them differently, leaves it a no-op that surfaces later as an unrelated resolution failure. Verified by resolving build dependencies for resolute-qcom-devel in the pkg-builder:resolute image with deb-src disabled: debian/rules clean followed by "apt-get build-dep -y ./" installs its 134 packages and succeeds. Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
The build container ran with --privileged, which disables namespace and capability isolation for the whole container. Nothing in this path needs it: the kernel is compiled and packaged with fakeroot, and the sbuild unshare backend that does need id mapping is not used here. Verified by running the build setup for resolute-qcom-devel in pkg-builder:resolute without it. Installing the Qualcomm repository, debian/rules clean, and resolving the 134 build dependencies all succeed unprivileged. Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
Bjordis Collaku (bjordiscollaku)
force-pushed
the
ci/phase2-repo-and-suffix
branch
from
October 8, 2026 17:28
7ce0eb8 to
a91e58a
Compare
Bjordis Collaku (bjordiscollaku)
force-pushed
the
ci/phase4-debsrc-and-privileged
branch
from
October 8, 2026 17:28
a0eda06 to
81dce84
Compare
This was referenced Oct 8, 2026
Bjordis Collaku (bjordiscollaku)
marked this pull request as ready for review
October 9, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134, closes #135.
Stacked on #129. That PR should be reviewed first; the diff here is only the two commits on this branch.
deb-src. The edit was needed while build dependencies were resolved by source package name, which reads the archive Sources index. They have been resolved from the local tree since
apt-get build-dep -y ./, which reads the generateddebian/control. The edit is also silent when it does nothing, matchingTypes: debin one DEB822 file by exact name, so a differently formatted or named base image leaves a no-op that surfaces later as an unrelated resolution failure.Privileged container. Nothing in this path needs it. The kernel is compiled and packaged with
fakeroot, and the sbuild unshare backend that does need id mapping is not used here.Both were confirmed in
pkg-builder:resoluteagainstresolute-qcom-devel: withdeb-srcdisabled and no--privileged, installing the Qualcomm repository,debian/rules cleanand resolving the 134 build dependencies all succeed.A full CI build has since been run from the top of this stack (run 37965472447, both flavours with debug packages): no
--privileged, no deb-src edit, and all 13 packages compiled, packaged and uploaded.