chore: remove unused FakeEventSource

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Sep 18, 2025 6:06am

[NathanFlurry]

• chore(core): fix missing transport for inline tests #1287 : 2 dependent PRs (#1250 , #1289 )
• chore(core): fix test for sending message to specific connection sse race condition #1286
• fix(cloudflare-workers): fix alarms #1285
• chore(core): fix broadcast race condition #1284
• chore: list sideEffects #1283
• chore(core): fix connection tests to support sse #1282
• fix(cloudflare-workers): fix aborts on sse streams on cloudflare workers #1281
• fix(cloudflare-workers): fix aborting sse streams #1280
• chore: remove unused FakeEventSource #1279 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1279: Remove Unused FakeEventSource

Todo List

• Read repository guidelines (CLAUDE.md)
• Search codebase for FakeEventSource references
• Check for imports and usage patterns
• Verify test dependencies
• Provide comprehensive review feedback

Review Summary

✅ APPROVED - This PR safely removes unused code without any impact on the codebase.

Analysis

Code Quality & Best Practices

• Clean removal: The deletion of packages/rivetkit/src/common/fake-event-source.ts (267 lines) appears to be a proper cleanup of unused code
• No orphaned references: Comprehensive search found no remaining imports or usage of FakeEventSource anywhere in the codebase
• Follows project conventions: Aligns with the repository's preference for keeping the codebase clean (as mentioned in CLAUDE.md guidelines)

Potential Issues

• None identified: The removal appears safe with no breaking changes
• Similar naming concern: Found one reference to "fake-event-source2" in the logger at packages/rivetkit/src/common/inline-websocket-adapter2.ts:11, but this is:
  • A different implementation (InlineWebSocketAdapter2 vs the removed FakeEventSource)
  • Just a logger name string, not an actual dependency
  • Appears to be intentionally separate based on the 2 suffix

Security & Performance

• Security: No security concerns - removing unused code reduces attack surface
• Performance: Positive impact - smaller bundle size and reduced maintenance burden
• No runtime impact: Since the code was unused, removal has no functional impact

Test Coverage

• No test dependencies: Verified that no test files reference FakeEventSource
• No broken imports: The removal doesn't break any existing test suites

Recommendations

1. Consider documenting: While not required for this simple removal, consider adding a brief description to future PRs explaining why code is being removed
2. Validate similar files: The presence of InlineWebSocketAdapter2 suggests there might be other numbered versions that could be candidates for similar cleanup

Conclusion

This is a straightforward and safe cleanup PR that removes genuinely unused code. The removal follows best practices and poses no risks to the codebase functionality, security, or performance.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1279

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1279

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1279

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1279

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1279

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1279

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1279

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1279

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1279

commit: 6518d37