fix(cloudflare-workers): fix alarms

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Sep 18, 2025 6:05am

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(core): fix missing transport for inline tests #1287 : 2 dependent PRs (#1250 , #1289 )
• chore(core): fix test for sending message to specific connection sse race condition #1286
• fix(cloudflare-workers): fix alarms #1285 👈 (View in Graphite)
• chore(core): fix broadcast race condition #1284
• chore: list sideEffects #1283
• chore(core): fix connection tests to support sse #1282
• fix(cloudflare-workers): fix aborts on sse streams on cloudflare workers #1281
• fix(cloudflare-workers): fix aborting sse streams #1280
• chore: remove unused FakeEventSource #1279
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for Alarm Fix

Reviewing PR #1285: fix(cloudflare-workers): fix alarms

Todo List

• Read and analyze the modified file
• Evaluate code quality and implementation
• Check for potential bugs and security issues
• Assess performance implications
• Review test coverage considerations
• Provide comprehensive feedback

Summary

This PR fixes the alarm() method in the Cloudflare Workers actor handler by simplifying the implementation and reusing the already-loaded actor driver instead of creating a new one.

Code Quality ✅ Good

Positive Changes:

• DRY Principle: The fix eliminates code duplication by reusing the actorDriver from #loadActor() instead of recreating the entire driver stack
• Consistency: The LoadedActor interface now properly includes actorDriver, making the abstraction more complete
• Simplification: Removed 15 lines of redundant driver setup code

Bug Fixes ✅ Addresses Real Issues

Problems Solved:

1. Driver Instance Mismatch: The original code created a new actorDriver instance for alarms, which could lead to state inconsistencies since it wouldn't share the same driver instance as regular requests
2. Resource Waste: Creating new manager and actor drivers for each alarm was inefficient
3. Missing Type Safety: The LoadedActor interface was incomplete without actorDriver

Performance ✅ Improved

Before vs After:

• Before: Created new managerDriver, inlineClient, and actorDriver for each alarm
• After: Reuses existing driver instances from #loadActor()
• Impact: Reduces object creation overhead and ensures consistency with cached state

Security 🔍 No Concerns

• No security implications identified
• The change maintains the same access patterns and doesn't introduce new attack vectors
• Proper use of existing abstractions and encapsulation

Potential Issues 🤔 Minor Considerations

1. Error Handling: The alarm() method doesn't have explicit error handling around actorDriver.loadActor() or actor._onAlarm(). Consider whether alarm failures should be logged or handled gracefully.

2. Type Safety: The destructuring const { actorDriver } = await this.#loadActor(); assumes actorDriver will always be present, which should be true but could benefit from an assertion.

Test Coverage 📋 Needs Attention

• No alarm-specific tests found in the test directory
• Consider adding tests for:
  • Alarm triggering after actor initialization
  • Alarm behavior when actor is not yet loaded
  • Error scenarios in alarm handling

Code Style ✅ Follows Conventions

• Consistent with existing codebase patterns
• Proper TypeScript usage
• Follows the repository's logging conventions with logger().debug()

Recommendation

Approve ✅ This is a solid fix that addresses real architectural issues. The changes are minimal, focused, and improve both performance and correctness.

Suggested Follow-ups:

1. Add unit tests for alarm functionality
2. Consider adding error handling/logging for alarm failures
3. Document the alarm behavior in the actor lifecycle

---

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1285

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1285

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1285

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1285

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1285

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1285

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1285

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1285

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1285

commit: af9733a

[graphite-app]

Merge activity

• Sep 24, 6:06 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Sep 24, 6:07 AM UTC: CI is running for this pull request on a draft pull request (#1294) due to your merge queue CI optimization settings.
• Sep 24, 6:08 AM UTC: Merged by the Graphite merge queue via draft PR: #1294.