chore(core): fix test for sending message to specific connection sse race condition

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Sep 18, 2025 7:13pm

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Fix test for sending message to specific connection SSE race condition

I've analyzed the changes to fix the SSE race condition test. Here's my comprehensive review:

Todo List

• Read and analyze the modified test file
• Understand the race condition fix implementation
• Evaluate code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage and effectiveness
• Provide comprehensive feedback

📋 Summary

This PR wraps the message sending and verification logic in vi.waitFor() to address a race condition between SSE subscription and message publishing.

✅ Positive Aspects

Effective Race Condition Fix

• The solution correctly addresses the timing issue where messages might be sent before SSE subscriptions are fully established
• Using vi.waitFor() allows the test to retry until the expected state is achieved, which is appropriate for asynchronous systems

Maintains Test Integrity

• All original assertions are preserved within the waitFor block
• The test still verifies both success return value and message reception
• No test coverage is lost in the refactoring

Follows Existing Patterns

• Consistent with other race condition fixes in the same test file (lines 159-162, 174-185)
• Uses the same testing utility (vi.waitFor) as other connection lifecycle tests

⚠️ Issues and Recommendations

Critical: Missing Timeout Configuration

// Current - uses default timeout
await vi.waitFor(async () => {
  // test logic
});

// Recommended - explicit timeout like other tests
await vi.waitFor(async () => {
  // test logic  
}, {
  timeout: 10_000,
  interval: 100,
});

Reference: Lines 181-184 show proper timeout configuration for SSE-related tests

Code Quality: TODO Comment Typo

// Line 240: "subscrib eand" should be "subscribe and"
// TODO: SSE has race condition between subscrib eand publish message

Consistency Issue: Use of vi.waitFor vs waitFor
The CLAUDE.md guidelines state: "Using setTimeout in tests & test actors will not work unless you call await waitFor(driverTestConfig, <ts>)"

However, this test uses vi.waitFor() which is appropriate for Vitest's retry mechanism, while the project's waitFor() utility is for timer advancement. The current usage is correct for this race condition scenario.

🔒 Security & Performance

Security: ✅ No security concerns identified

• Test only validates connection messaging functionality
• No sensitive data exposure or injection risks

Performance: ✅ Acceptable with minor concern

• Default timeout may be too permissive for this specific test
• Recommend explicit timeout configuration to prevent unnecessarily long test runs

🧪 Test Coverage Assessment

Coverage: ✅ Excellent

• All original assertions maintained
• Race condition properly addressed
• Test remains deterministic and reliable

📝 Recommendations

1. Add explicit timeout configuration (Critical)
2. Fix typo in TODO comment (Minor)
3. Consider adding a brief comment explaining why vi.waitFor is needed (Optional)

Final Assessment

This is a solid fix that effectively addresses the SSE race condition while maintaining test reliability. The main issue is the missing timeout configuration, which should be added for consistency with other SSE-related tests in the same file.

Approval Status: ✅ Approve with minor changes recommended

---

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(core): fix missing transport for inline tests #1287 : 2 dependent PRs (#1250 , #1289 )
• chore(core): fix test for sending message to specific connection sse race condition #1286 👈 (View in Graphite)
• fix(cloudflare-workers): fix alarms #1285
• chore(core): fix broadcast race condition #1284
• chore: list sideEffects #1283
• chore(core): fix connection tests to support sse #1282
• fix(cloudflare-workers): fix aborts on sse streams on cloudflare workers #1281
• fix(cloudflare-workers): fix aborting sse streams #1280
• chore: remove unused FakeEventSource #1279
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1286

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1286

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1286

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1286

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1286

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1286

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1286

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1286

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1286

commit: e60c269

[graphite-app]

Merge activity

• Sep 24, 6:06 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Sep 24, 6:07 AM UTC: CI is running for this pull request on a draft pull request (#1294) due to your merge queue CI optimization settings.
• Sep 24, 6:08 AM UTC: Merged by the Graphite merge queue via draft PR: #1294.