Repository navigation
Prepare Hydrogen commands for typed JSON output - #4095
Open
gonzaloriestra wants to merge 8 commits into
Open
gonzaloriestra wants to merge 8 commits into
gonzaloriestra wants to merge 8 commits into
Conversation
This was referenced Sep 28, 2026
gonzaloriestra
added this pull request to stack #4104
September 28, 2026 15:14
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
2 times, most recently
from
September 28, 2026 15:38
f6fd624 to
e0da655
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
2 times, most recently
from
September 29, 2026 14:53
60a805a to
806fac6
Compare
fredericoo
approved these changes
Sep 29, 2026
fredericoo
left a comment
Contributor
There was a problem hiding this comment.
nice groundwork for the stack - the init hook tests covering --, --path=, help/schema and the env flag are really thorough, and good to see the task adapter gone now the nightly has cli#8672. One small comment on how alerts get flattened in JSON mode, nothing blocking.
fredericoo
reviewed
Sep 29, 2026
fredericoo
left a comment
Contributor
There was a problem hiding this comment.
a couple of follow-up questions I forgot to include earlier, neither blocking the approval
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
from
October 6, 2026 12:02
806fac6 to
ee17b8b
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
from
October 6, 2026 13:55
6c889de to
abd25ea
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
3 times, most recently
from
October 9, 2026 10:52
c1cf522 to
6084f4e
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
from
October 9, 2026 12:25
6084f4e to
7eebc52
Compare
gonzaloriestra
marked this pull request as ready for review
October 9, 2026 12:28
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
2 times, most recently
from
October 9, 2026 13:29
53540a3 to
bccc3e7
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-support
branch
from
October 9, 2026 14:01
bccc3e7 to
29a0fc8
Compare
kdaviduik
requested changes
Oct 9, 2026
kdaviduik
left a comment
Contributor
There was a problem hiding this comment.
Hydrogen 2 is now on the 2026-04 branch, please change the base branch for this stack to merge into 2026-04 instead :)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Finite Hydrogen commands need shared schema and error support before exposing reliable JSON results.
WHAT is this pull request doing?
Pin Shopify CLI and CLI Kit to the matching stable release (
4.9.0), add shared contracts and real-stream capture, and validate project and disabled-command rules in the command lifecycle so CLI Kit emits standard fatal errors. Expose--no-inputthrough shared flags so prompt and browser-authentication policy remains independent from--json. Use CLI Kit UI helpers directly, keep VM startup in the init hook, and keep JSON diagnostics on stderr.HOW to test your changes?
pnpm --filter @shopify/cli-hydrogen build pnpm --filter @shopify/cli-hydrogen typecheck pnpm --filter @shopify/cli-hydrogen testVerified CLI 4.9.0 loads the Cloudflare
tunnel_providerandtunnel_starthooks from its root plugin. Hydrogen must not register the separate plugin again, which would duplicate tunnels. CPU startup profiling was checked against a built storefront and repeated runs with isolated globals. Built-in imports are restricted to an explicit allowlist without filesystem, network or process access. Like the Vite build that precedes it, this Node profiler runs trusted project code; its fresh VM context is not a security sandbox.Verified timer behavior with MiniOxygen's actual workerd runtime and Oxygen compatibility date
2025-04-01: bothsetTimeoutandsetIntervalat module scope fail with "Disallowed operation called within global scope". The profiler intentionally preserves that startup restriction; timers remain valid inside request handlers. Regression tests cover this and denied static/dynamic imports of host I/O built-ins.Checklist