Repository navigation
Add typed JSON output to Hydrogen project and account commands - #4101
gonzaloriestra wants to merge 3 commits into
Conversation
cb5cc4d to
d8ae8a8
Compare
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
d8ae8a8 to
8ee3647
Compare
8ee3647 to
bb0c78c
Compare
bb0c78c to
7c1c770
Compare
fredericoo
left a comment
There was a problem hiding this comment.
Went through this one. It's a clean follow-on from the rest of the stack: same jsonOutputSchema / writeJsonResult / descriptionForHelp pattern as the env and route PRs, results carry no tokens (login just picks shop/shopName/email), and the human-readable output looks unchanged for all six commands. Moving renderProjectReady and the remote-template info into presentTemplateResult is a nice split.
Prompts in --json mode look fine too. When stdout is piped, cli-kit's throwInNonTTY rejects them, so login/link/init fail fast with a JSON error instead of hanging.
Two small comments, neither blocking. Overall LGTM
7c1c770 to
dcdcdc1
Compare
dcdcdc1 to
1be2ea3
Compare
1be2ea3 to
cc9bfe3
Compare
cc9bfe3 to
d4bffcb
Compare
77a1bd0 to
3737a05
Compare
3737a05 to
47d6014
Compare
47d6014 to
5c987d7
Compare
13a2f13 to
71fe9b6
Compare
5885f8c to
e46187f
Compare
e46187f to
84e9347
Compare
84e9347 to
012ec34
Compare
6f3de2d to
573e4a1
Compare
573e4a1 to
d8a9f53
Compare
WHY are these changes introduced?
Project and account commands need predictable resource fields and complete initialization outcomes.
Fixes https://github.com/shop/issues-develop/issues/23682
WHAT is this pull request doing?
Expose explicit storefront projections with
gid,name, canonicalstoreDomain, null unavailable fields, and UTC timestamps. Add JSON login, logout, link, and unlink results. Initialization returns{status, project, failures}and preserves completed work while exiting nonzero on partial failure. Add minor changesets for CLI Hydrogen and create-hydrogen.HOW to test your changes?
Checklist