Repository navigation
Add typed JSON output to hydrogen deploy - #4098
Open
gonzaloriestra wants to merge 3 commits into
Open
gonzaloriestra wants to merge 3 commits into
gonzaloriestra wants to merge 3 commits into
Conversation
This was referenced Sep 28, 2026
gonzaloriestra
added this pull request to stack #4104
September 28, 2026 15:14
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
September 28, 2026 15:31
137c307 to
217879b
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
September 28, 2026 15:38
217879b to
f3d45cb
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
September 29, 2026 12:25
f3d45cb to
e3794de
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
September 29, 2026 14:53
e3794de to
589de46
Compare
fredericoo
approved these changes
Sep 29, 2026
fredericoo
left a comment
Contributor
There was a problem hiding this comment.
nice and simple - splitting executeDeploy from the presenter in runDeploy reads well, human-mode output is unchanged, and h2_deploy_log.json keeps the same bytes and stays independent of --json (with a test for it). Errors go through the shared JSON error path from #4095, and the two helpers that used to warn-and-return now throw in JSON mode so we don't end up emitting null for what's really a failure.
a couple of small comments on the JSON-mode custom build hook, otherwise LGTM
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 6, 2026 12:02
589de46 to
dc77b29
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
2 times, most recently
from
October 6, 2026 12:12
d2c14da to
ea80385
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
2 times, most recently
from
October 6, 2026 13:52
0e0d5b0 to
ccdc03f
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 6, 2026 13:55
ccdc03f to
b954a05
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 8, 2026 11:36
b954a05 to
088ecb3
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
2 times, most recently
from
October 9, 2026 10:52
5482acd to
da0e705
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 9, 2026 12:25
da0e705 to
d56b82f
Compare
gonzaloriestra
marked this pull request as ready for review
October 9, 2026 12:28
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 9, 2026 13:01
d56b82f to
7d66407
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
2 times, most recently
from
October 9, 2026 13:29
3e14095 to
8b8e1af
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 9, 2026 14:01
8b8e1af to
a213a34
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-deploy
branch
from
October 13, 2026 11:03
a213a34 to
e251a41
Compare
gonzaloriestra
removed this pull request from stack #4104
October 13, 2026 11:03
gonzaloriestra
added this pull request to stack #4177
October 13, 2026 11:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Deployment needs a finite result that reports successful and declined operations consistently.
Fixes https://github.com/shop/issues-develop/issues/23679
WHAT is this pull request doing?
Return
{status, deployment}with validated URLs and null unavailable bypass tokens. Preserve the native OxygenCompletedDeploymentbytes inh2_deploy_log.json;--json-outputstill controls that CI file independently from--json.HOW to test your changes?
Checklist