Repository navigation
Add typed JSON output to Hydrogen build tooling - #4096
Merged
Merged
Conversation
This was referenced Sep 28, 2026
gonzaloriestra
added this pull request to stack #4104
September 28, 2026 15:14
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
September 28, 2026 15:31
75cb4b0 to
db7eb48
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
September 28, 2026 15:38
db7eb48 to
7052847
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
September 29, 2026 12:25
7052847 to
43c52f2
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
September 29, 2026 14:53
43c52f2 to
d964345
Compare
fredericoo
approved these changes
Sep 29, 2026
fredericoo
left a comment
Contributor
There was a problem hiding this comment.
nice and tidy - pulling checkRoutes out as a pure function returning the domain result is a good shape, and the human output looks unchanged. A few small comments, mainly Vite's TTY progress output possibly getting into stdout in JSON mode, and codegen detecting --json differently from build/check.
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
5 times, most recently
from
October 6, 2026 13:52
362712c to
fa04237
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 6, 2026 13:55
fa04237 to
07dc587
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 8, 2026 11:36
07dc587 to
e78f1b7
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
2 times, most recently
from
October 9, 2026 10:52
b0dead5 to
f103f6c
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 9, 2026 12:25
f103f6c to
0acb4bb
Compare
gonzaloriestra
marked this pull request as ready for review
October 9, 2026 12:28
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 9, 2026 13:01
0acb4bb to
b5ba0a9
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 9, 2026 13:02
b5ba0a9 to
74a3ae5
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 9, 2026 13:30
74a3ae5 to
5d186d9
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 9, 2026 14:01
5d186d9 to
55b9aae
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 13, 2026 11:03
55b9aae to
74ab149
Compare
gonzaloriestra
removed this pull request from stack #4104
October 13, 2026 11:03
gonzaloriestra
added this pull request to stack #4177
October 13, 2026 11:04
andguy95
reviewed
Oct 13, 2026
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
2 times, most recently
from
October 14, 2026 09:52
9fcbaf8 to
61a9567
Compare
andguy95
approved these changes
Oct 14, 2026
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-json-build
branch
from
October 15, 2026 09:50
61a9567 to
2d81538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Build, route validation, and code generation need typed results that scripts can consume.
Fixes https://github.com/shop/issues-develop/issues/23677
WHAT is this pull request doing?
Add strict schemas and
--jsonto build, check, and codegen. Return absolute artifact paths, a validationvalidfield, and named generated files with source patterns. Keep diagnostics on stderr and reject finite JSON output with watch mode.HOW to test your changes?
Checklist