Skip to content

Conversation

Zeophlite
Copy link
Contributor

@Zeophlite Zeophlite commented Oct 14, 2025

Objective

  • Move MaterialProperties from bevy_pbr to bevy_material (new crate that doesn't depend on wgpu , just wgpu-types )

Solution

  • Move stuff, mainly look at these 3 crates:
    • from bevy_pbr to bevy_material
    • from bevy_render to bevy_material
    • from bevy_pbr to bevy_render

Testing

  • Builds

Copy link
Contributor

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen M-Needs-Release-Note Work that should be called out in the blog due to impact labels Oct 15, 2025
Copy link
Contributor

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes X-Controversial There is active debate or serious implications around merging this PR D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Oct 15, 2025
@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Oct 15, 2025
@Zeophlite Zeophlite requested a review from atlv24 October 16, 2025 07:12
@Zeophlite Zeophlite removed the S-Blocked This cannot move forward until something else changes label Oct 17, 2025
@Zeophlite Zeophlite force-pushed the mat-prop4 branch 2 times, most recently from db3dad3 to 23ef4e8 Compare October 17, 2025 07:16
@Zeophlite
Copy link
Contributor Author

Zeophlite commented Oct 17, 2025

I suggest reviewing commit by commit - commits are now in the following order:

  • Boilerplate for bevy_material and bevy_material_macros
  • Conversions required later on (e.g. From<World> changes, etc.)
  • Moves (generally one file at a time)

Have a look at the migration guide for a summary of all moves

@Zeophlite Zeophlite marked this pull request as ready for review October 17, 2025 07:23
@Zeophlite Zeophlite added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 17, 2025
…rialKey, ErasedMaterialKeyVTable, RenderPhaseType
…MeshInstanceFlags, RenderMeshInstanceCpu, RenderMeshInstanceGpu, PreviousGlobalTransform, RenderMeshInstanceShared, remove_mesh_input_uniform to bevy_render
…EXTRACTION_THRESHOLD_FACTOR, SkinByteOffset, SkinUniforms, SkinUniformInfo to bevy_render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Controversial There is active debate or serious implications around merging this PR

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants