Skip to content

Reduce overtime in relay_render_to_plane#11901

Merged
hry-gh merged 2 commits intocmss13-devs:masterfrom
noelle-lavenza:fix/rrtp-overtime
Mar 20, 2026
Merged

Reduce overtime in relay_render_to_plane#11901
hry-gh merged 2 commits intocmss13-devs:masterfrom
noelle-lavenza:fix/rrtp-overtime

Conversation

@noelle-lavenza
Copy link
Copy Markdown
Contributor

About the pull request

Instead of checking in screen in relay_render_to_plane, we check an alist that exists specifically for this purpose. This ensures we don't have to loop over the entire screen list searching for each relay. That saves a ton of overtime.

We also don't recreate the planemaster's relay if it already exists. This seems to have saved the rest of the overtime, because now it's extremely low per call.

Explain why it's good for the game

Reduces overtime from 1.93568 per 292193 calls to a projected 0.2783 per 292193 calls (actual numbers are 0.002/2100, so it could be slightly better in practice due to rounding).

With a second change, I was able to get it even lower: for spamming F12 to call show_hud() over and over again, it was 0.001/6755, which is 0.0433 overtime per call. When spamming aghost and Re-enter corpse, it actually had an overtime of 0 for 3465 calls, which is incredible. Everything looks fine as well!

I would feel most comfortable if this was testmerged, but it seemed alright in local testing, at least.

Testing Photographs and Procedure

Runtime map looks fine, stairs aren't broken, openspace isn't broken, darkness/lighting isn't broken.

Screenshots & Videos image image

Changelog

🆑 MoondancerPony
refactor: refactored plane render relay plate code to reduce overtime lag from observing and changing mobs
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Mar 7, 2026
@cmss13-ci cmss13-ci Bot added Refactor Make the code harder to read size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Mar 7, 2026
@cm13-github
Copy link
Copy Markdown
Contributor

cm13-github commented Mar 8, 2026

Test merge deployment history:

Test Merge Deployed @ 03/08/2026 21:49:07 +00:00:
Server Instance

CM13 Live

Revision

Origin: 864091c
Pull Request: ae81d26
Server: 2cbe3d2

Test Merge Updated @ 03/09/2026 00:45:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0cbb7e5
Pull Request: ae81d26
Server: 5a97a35

Test Merge Updated @ 03/09/2026 01:12:33 +00:00:
Server Instance

CM13 Live

Revision

Origin: cb54193
Pull Request: ae81d26
Server: 65bf557fe0deb74cfe48d69e35e12ebcbc38c1e3

Test Merge Updated @ 03/09/2026 02:43:29 +00:00:
Server Instance

CM13 Live

Revision

Origin: 875069c
Pull Request: ae81d26
Server: 304d72e358bed79142ccd24e752bcac21660aa87

Test Merge Updated @ 03/09/2026 08:45:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: d5dbcb1
Pull Request: ae81d26
Server: 614860872e31ec25e7abe5348e3da88099bf90f7

Test Merge Updated @ 03/09/2026 10:08:59 +00:00:
Server Instance

CM13 Live

Revision

Origin: d5dbcb1
Pull Request: ae81d26
Server: c7fa723

Test Merge Updated @ 03/09/2026 11:16:28 +00:00:
Server Instance

CM13 Live

Revision

Origin: 63fcc66
Pull Request: ae81d26
Server: 8b361c13bb30d51256efa45187562536ffd60f96

Test Merge Updated @ 03/09/2026 11:45:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 63fcc66
Pull Request: ae81d26
Server: fea05db

Test Merge Updated @ 03/09/2026 12:27:54 +00:00:
Server Instance

CM13 Live

Revision

Origin: 63fcc66
Pull Request: ae81d26
Server: 4bf1827

Test Merge Updated @ 03/09/2026 15:13:39 +00:00:
Server Instance

CM13 Live

Revision

Origin: 63fcc66
Pull Request: ae81d26
Server: b4e7703

Test Merge Updated @ 03/10/2026 02:49:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: e7e259d
Pull Request: ae81d26
Server: acb6cc122a930f959f12137d46445873d1298aa7

Test Merge Updated @ 03/10/2026 08:51:41 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30a6de7
Pull Request: ae81d26
Server: a21874cc40d2e10d9f7708b776308d1358b7867b

Test Merge Updated @ 03/10/2026 09:52:36 +00:00:
Server Instance

CM13 Live

Revision

Origin: 53e8ba0
Pull Request: ae81d26
Server: 63dcf09a11cf7542ce9b1660f429d47e19f2360b

Test Merge Updated @ 03/10/2026 13:56:42 +00:00:
Server Instance

CM13 Live

Revision

Origin: 53e8ba0
Pull Request: ae81d26
Server: 217a597

Test Merge Updated @ 03/10/2026 17:24:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4b6681b
Pull Request: ae81d26
Server: 9f16eae0cc0252384189b3a333e48c4008ebbcd7

Test Merge Updated @ 03/10/2026 17:55:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 75bcb13
Pull Request: ae81d26
Server: 6f794303e63a10b663bdb1b6ec19d4292657d604

Test Merge Updated @ 03/11/2026 02:27:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: 611e728
Pull Request: ae81d26
Server: 90deb9ca53ef9accbfb79bac56359a09c0a0104d

Test Merge Updated @ 03/11/2026 04:28:53 +00:00:
Server Instance

CM13 Live

Revision

Origin: 2c730bb
Pull Request: ae81d26
Server: e9d1d56

Test Merge Updated @ 03/11/2026 14:05:36 +00:00:
Server Instance

CM13 Live

Revision

Origin: 2c730bb
Pull Request: ae81d26
Server: 014d111

Test Merge Updated @ 03/12/2026 02:33:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1134dab
Pull Request: ae81d26
Server: 95afbdf604761a56a8b08da9674723def44ef5b8

Test Merge Updated @ 03/13/2026 06:39:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4b19a3f
Pull Request: ae81d26
Server: 80944b3fc7a20ec6f4e71e634cf326a8242e38a4

Test Merge Updated @ 03/13/2026 09:40:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4b19a3f
Pull Request: ae81d26
Server: 4eeb290

Test Merge Updated @ 03/13/2026 12:41:50 +00:00:
Server Instance

CM13 Live

Revision

Origin: 91f9a91
Pull Request: ae81d26
Server: 3f19798148c2ce3bcbc855e074191a1b7de27add

Test Merge Updated @ 03/13/2026 13:05:34 +00:00:
Server Instance

CM13 Live

Revision

Origin: d3a635b
Pull Request: ae81d26
Server: c439e8f

Test Merge Updated @ 03/13/2026 13:12:37 +00:00:
Server Instance

CM13 Live

Revision

Origin: c9011d1
Pull Request: ae81d26
Server: 4d8d54193c7d70d4fc6f207f92b03528321da76c

Test Merge Updated @ 03/13/2026 13:43:23 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6184775
Pull Request: ae81d26
Server: faa8da36c5e3ee9c52f754d2745725d6b901da5b

Test Merge Updated @ 03/13/2026 18:44:59 +00:00:
Server Instance

CM13 Live

Revision

Origin: c986c9d
Pull Request: ae81d26
Server: 88ba5f93e2bd5aaffa0fa47361c3e24eb8bd1289

Test Merge Updated @ 03/14/2026 02:46:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: a147345
Pull Request: ae81d26
Server: 24c3eea98895a657fa77de7970d65d004fa929d4

Test Merge Updated @ 03/16/2026 09:26:15 +00:00:
Server Instance

CM13 Live

Revision

Origin: afc0051
Pull Request: ae81d26
Server: 6a198e8e910085f3df58b9d934bdf859347b0e32

Test Merge Updated @ 03/16/2026 20:17:14 +00:00:
Server Instance

CM13 Live

Revision

Origin: afc0051
Pull Request: ae81d26
Server: 46f653c

Test Merge Updated @ 03/16/2026 21:29:13 +00:00:
Server Instance

CM13 Live

Revision

Origin: e73c57e
Pull Request: ae81d26
Server: 5d84aecc980e261c7de24b2c73ba871292b7b5b5

Test Merge Updated @ 03/16/2026 21:30:33 +00:00:
Server Instance

CM13 Live

Revision

Origin: e73c57e
Pull Request: ae81d26
Server: 5e02e41

Test Merge Updated @ 03/16/2026 21:59:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4d66394
Pull Request: ae81d26
Server: c78f804f4800c2e75664aebc7a38b36d0c83aaee

Test Merge Updated @ 03/17/2026 00:57:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4d66394
Pull Request: ae81d26
Server: ec24430

Test Merge Updated @ 03/17/2026 01:46:15 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4d66394
Pull Request: ae81d26
Server: 321cf15

Test Merge Updated @ 03/17/2026 02:31:26 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0d9cbf2
Pull Request: ae81d26
Server: 1b49a4507d1febf77690cf36dda1b9fea34d41e3

Test Merge Updated @ 03/17/2026 02:53:26 +00:00:
Server Instance

CM13 Live

Revision

Origin: b304362
Pull Request: ae81d26
Server: 72236db

Test Merge Updated @ 03/17/2026 20:00:07 +00:00:
Server Instance

CM13 Live

Revision

Origin: b304362
Pull Request: ae81d26
Server: 9c28cb9

Test Merge Updated @ 03/17/2026 22:24:26 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9a95d10
Pull Request: ae81d26
Server: 5ea5890

Test Merge Updated @ 03/17/2026 23:40:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9a95d10
Pull Request: ae81d26
Server: 93ba754

Test Merge Updated @ 03/18/2026 03:07:32 +00:00:
Server Instance

CM13 Live

Revision

Origin: 51f3b4b
Pull Request: ae81d26
Server: 56ee3bfc96529ccc4a9d4e6e6eb4efdef07fc266

Test Merge Updated @ 03/18/2026 05:08:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9abc743
Pull Request: ae81d26
Server: 08b6d46995906fb23f65405dee3f12f55a6564ff

Test Merge Updated @ 03/18/2026 05:39:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4d2164b
Pull Request: ae81d26
Server: af268157ba40c87121ac5ad23b637e1ca402732a

Test Merge Updated @ 03/18/2026 21:44:05 +00:00:
Server Instance

CM13 Live

Revision

Origin: c878090
Pull Request: ae81d26
Server: c16ff64

Test Merge Updated @ 03/19/2026 00:45:27 +00:00:
Server Instance

CM13 Live

Revision

Origin: c878090
Pull Request: ae81d26
Server: 904bd62

Test Merge Updated @ 03/19/2026 02:16:31 +00:00:
Server Instance

CM13 Live

Revision

Origin: b4a0279
Pull Request: ae81d26
Server: 09a5818

Test Merge Updated @ 03/19/2026 02:47:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: 288df60
Pull Request: ae81d26
Server: 36db838

Test Merge Updated @ 03/19/2026 16:34:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 288df60
Pull Request: ae81d26
Server: d16d4de

Test Merge Updated @ 03/19/2026 17:51:17 +00:00:
Server Instance

CM13 Live

Revision

Origin: 288df60
Pull Request: ae81d26
Server: 36db838

Test Merge Updated @ 03/19/2026 19:22:19 +00:00:
Server Instance

CM13 Live

Revision

Origin: 288df60
Pull Request: ae81d26
Server: 252a3e4

Test Merge Updated @ 03/20/2026 08:25:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: 971c8c1
Pull Request: ae81d26
Server: 92cdb05d695875d636847d5906c466d8f9fe72c4

Test Merge Updated @ 03/20/2026 08:56:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 433514c
Pull Request: ae81d26
Server: e6511a824840eae120d2d7d65426f01924740825

Test Merge Updated @ 03/20/2026 09:27:28 +00:00:
Server Instance

CM13 Live

Revision

Origin: ca6a046
Pull Request: ae81d26
Server: 1e08d75e77d721426c43bce212b5a3028ea54342

Test Merge Removed @ 03/20/2026 18:48:55 +00:00:
Server Instance

CM13 Live

@github-project-automation github-project-automation Bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog Mar 20, 2026
@hry-gh hry-gh added this pull request to the merge queue Mar 20, 2026
@hry-gh hry-gh removed this pull request from the merge queue due to a manual request Mar 20, 2026
@hry-gh hry-gh added this pull request to the merge queue Mar 20, 2026
Merged via the queue into cmss13-devs:master with commit 423d7d0 Mar 20, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from Partially Approved / Mergeable to Merged in Review Backlog Mar 20, 2026
cmss13-ci Bot added a commit that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Make the code harder to read size/M Denotes a PR that changes 50-199 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants