Repository navigation
Fix non-constant format string error on go 1.26 - #3392
Conversation
|
There's couple more occasions of same use across our repos: #3387 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
+ Coverage 74.85% 74.88% +0.02%
==========================================
Files 189 189
Lines 8349 8349
==========================================
+ Hits 6250 6252 +2
+ Misses 1854 1853 -1
+ Partials 245 244 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
Until downstream Serving repo is resolved. /hold |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes address the Go 1.26 diagnostic without unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Go 1.26 format-string validation errors while preserving condition messages.
Changes:
- Uses a constant
%sformat for dynamic messages. - Updates the Go module directive to 1.26.0.
| File | Description |
|---|---|
testing/duck/testbindable.go |
Fixes the non-constant format string call. |
go.mod |
Sets the required Go version to 1.26.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/unhold |
Changes
Bumping go directive in
go.modto force error fix verification through unit tests. The 1.26'sgo vetis has tighter recognition of string formatters not being present.Appeared here: #3391
Release Note
/cc @gauron99 @kahirokunn