Skip to content

feat: add slackbot.skills.create method - #1685

Merged
zimeg merged 9 commits into
mainfrom
zimeg-feat-slackbot-skills-create
Nov 13, 2026
Merged

zimeg merged 9 commits into
mainfrom
zimeg-feat-slackbot-skills-create

Conversation

@zimeg

@zimeg zimeg commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

This pull request adds the slackbot.skills.create method to the sync and async clients.

  • slackbotSkillsCreate takes displayName (required), instructions or canvasId (exactly one), description, category, examplePrompt, and mcpServers.
  • Adds the com.slack.api.model.slackbot.Skill model, which the create, info, list and update responses share.
  • mcpServers takes the request's nested McpServer class (serviceType, appId, serverId), sent as a JSON array of {service_type, app_id, server_id} objects. The API rejects strings and any other keys. The response's own nested McpServer types invalid_mcp_servers, which lists declared apps that can't be found.
  • JsonDataRecorder writes a typed sample for empty mcp_servers arrays instead of "".
  • SlackbotTest parses a response captured from the live API with unknown properties failing the test, so every returned field is typed.

This is part 1 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.

  1. feat: add slackbot.skills.create method #1685 slackbot.skills.create 👈 this pull request
  2. feat: add slackbot.skills.info method #1686 slackbot.skills.info
  3. feat: add slackbot.skills.update method #1687 slackbot.skills.update
  4. feat: add slackbot.skills.list method #1688 slackbot.skills.list
  5. feat: add slackbot.skills.library.add method #1689 slackbot.skills.library.add
  6. feat: add slackbot.skills.library.remove method #1690 slackbot.skills.library.remove
  7. feat: add admin.slackbot.skills.list method #1691 admin.slackbot.skills.list
  8. feat: add admin.slackbot.skills.publish method #1692 admin.slackbot.skills.publish
  9. feat: add admin.slackbot.skills.setAutoEnabled method #1693 admin.slackbot.skills.setAutoEnabled
  10. feat: add admin.slackbot.skills.unpublish method #1694 admin.slackbot.skills.unpublish
  11. feat: add slackbot.skills.delete method #1695 slackbot.skills.delete

Testing

Run the remote tests for this layer:

  • test_with_remote_apis.methods.slackbot_skills_Test with SLACK_SDK_TEST_BOT_TOKEN (canvases:write, skills:read, skills:write)

Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

Adds the slackbot.skills.create Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.75%. Comparing base (c847d97) to head (d1c12a6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1685      +/-   ##
============================================
- Coverage     73.75%   73.75%   -0.01%     
- Complexity     4679     4684       +5     
============================================
  Files           487      487              
  Lines         14669    14684      +15     
  Branches       1528     1529       +1     
============================================
+ Hits          10819    10830      +11     
- Misses         2939     2944       +5     
+ Partials        911      910       -1     
Flag Coverage Δ
jdk-14 73.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Parses a live slackbot.skills.create response with unknown properties failing the test.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg marked this pull request as ready for review November 12, 2026 23:43
@zimeg
zimeg requested a review from a team as a code owner November 12, 2026 23:43
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧮 some ordering findings before meaningful checks - we're not sure of what's best . just wanting consistent

Comment thread metadata/web-api/rate_limit_tiers.json Resolved
Comment on lines 447 to 449
setRateLimitTier(SLACKBOT_SKILLS_CREATE, Tier2);

setRateLimitTier(SLACKLISTS_ACCESS_DELETE, Tier3);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 these should match same orderings elsewehre however decided

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these match now. slackbot.skills.* comes after slackLists.* here and in Methods, MethodsClient, AsyncMethodsClient, both implementations, RequestFormBuilder and MethodsTest. That matches the docs, the imports and the generated rate_limit_tiers.json. It is cascaded up through #1695.

zimeg and others added 4 commits November 12, 2026 16:28
Matches the order on docs.slack.dev/reference/methods, the imports
(slack_lists before slackbot) and the generated rate_limit_tiers.json.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mcp_servers on slackbot.skills.create now takes the request's own
McpServer class with service_type, app_id and server_id, and the
separate SkillMcpServer model is removed. invalid_mcp_servers in the
response uses the same class.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
SlackbotSkillsCreateRequest.McpServer replaces it.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
invalid_mcp_servers uses the response's own McpServer class instead of
importing the request's.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Parsing a live API response with unknown properties failing the test is a great way to make sure every Skill field is typed.

zimeg and others added 2 commits November 12, 2026 18:34
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Local method tests are named for the top-level namespace, like ChatTest
for chat.scheduledMessages and CanvasesTest for canvases.access.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg

zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

Thank you so much @mwbrooks for the thoughtful review! 💛 Really glad the live-capture parsing test landed well, it gave us a lot of confidence that every Skill field is typed. Merging this first layer now 🚢

@zimeg
zimeg merged commit d0a4d89 into main Nov 13, 2026
7 checks passed
@zimeg
zimeg deleted the zimeg-feat-slackbot-skills-create branch November 13, 2026 03:11
@zimeg zimeg mentioned this pull request Nov 13, 2026
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants