Repository navigation
feat: add slackbot.skills.create method - #1685
Conversation
Adds the slackbot.skills.create Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
============================================
- Coverage 73.75% 73.75% -0.01%
- Complexity 4679 4684 +5
============================================
Files 487 487
Lines 14669 14684 +15
Branches 1528 1529 +1
============================================
+ Hits 10819 10830 +11
- Misses 2939 2944 +5
+ Partials 911 910 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Parses a live slackbot.skills.create response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
left a comment
There was a problem hiding this comment.
🧮 some ordering findings before meaningful checks - we're not sure of what's best . just wanting consistent
| setRateLimitTier(SLACKBOT_SKILLS_CREATE, Tier2); | ||
|
|
||
| setRateLimitTier(SLACKLISTS_ACCESS_DELETE, Tier3); |
There was a problem hiding this comment.
🔍 these should match same orderings elsewehre however decided
There was a problem hiding this comment.
Thanks, these match now. slackbot.skills.* comes after slackLists.* here and in Methods, MethodsClient, AsyncMethodsClient, both implementations, RequestFormBuilder and MethodsTest. That matches the docs, the imports and the generated rate_limit_tiers.json. It is cascaded up through #1695.
Matches the order on docs.slack.dev/reference/methods, the imports (slack_lists before slackbot) and the generated rate_limit_tiers.json. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mcp_servers on slackbot.skills.create now takes the request's own McpServer class with service_type, app_id and server_id, and the separate SkillMcpServer model is removed. invalid_mcp_servers in the response uses the same class. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
SlackbotSkillsCreateRequest.McpServer replaces it. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
invalid_mcp_servers uses the response's own McpServer class instead of importing the request's. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Local method tests are named for the top-level namespace, like ChatTest for chat.scheduledMessages and CanvasesTest for canvases.access. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
Thank you so much @mwbrooks for the thoughtful review! 💛 Really glad the live-capture parsing test landed well, it gave us a lot of confidence that every |
This pull request adds the
slackbot.skills.createmethod to the sync and async clients.slackbotSkillsCreatetakesdisplayName(required),instructionsorcanvasId(exactly one),description,category,examplePrompt, andmcpServers.com.slack.api.model.slackbot.Skillmodel, which the create, info, list and update responses share.mcpServerstakes the request's nestedMcpServerclass (serviceType,appId,serverId), sent as a JSON array of{service_type, app_id, server_id}objects. The API rejects strings and any other keys. The response's own nestedMcpServertypesinvalid_mcp_servers, which lists declared apps that can't be found.JsonDataRecorderwrites a typed sample for emptymcp_serversarrays instead of"".SlackbotTestparses a response captured from the live API with unknown properties failing the test, so every returned field is typed.This is part 1 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.
slackbot.skills.create👈 this pull requestslackbot.skills.infoslackbot.skills.updateslackbot.skills.listslackbot.skills.library.addslackbot.skills.library.removeadmin.slackbot.skills.listadmin.slackbot.skills.publishadmin.slackbot.skills.setAutoEnabledadmin.slackbot.skills.unpublishslackbot.skills.deleteTesting
Run the remote tests for this layer:
test_with_remote_apis.methods.slackbot_skills_TestwithSLACK_SDK_TEST_BOT_TOKEN(canvases:write,skills:read,skills:write)Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code