Skip to content

feat: add slackbot.skills.update method - #1687

Merged
zimeg merged 36 commits into
mainfrom
zimeg-feat-slackbot-skills-update
Nov 13, 2026
Merged

zimeg merged 36 commits into
mainfrom
zimeg-feat-slackbot-skills-update

Conversation

@zimeg

@zimeg zimeg commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

This pull request adds the slackbot.skills.update method to the sync and async clients.

  • slackbotSkillsUpdate takes skillId (required), displayName, instructions, description, category, examplePrompt, and mcpServers.
  • mcpServers takes the request's nested McpServer class, and invalid_mcp_servers uses the response's own nested McpServer.
  • Sending an empty list for mcpServers sends [], which clears the list. Empty strings clear description, category and example_prompt.
  • SlackbotTest parses a response captured from the live API with unknown properties failing the test, so every returned field is typed.

This is part 3 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.

  1. feat: add slackbot.skills.create method #1685 slackbot.skills.create
  2. feat: add slackbot.skills.info method #1686 slackbot.skills.info
  3. feat: add slackbot.skills.update method #1687 slackbot.skills.update 👈 this pull request
  4. feat: add slackbot.skills.list method #1688 slackbot.skills.list
  5. feat: add slackbot.skills.library.add method #1689 slackbot.skills.library.add
  6. feat: add slackbot.skills.library.remove method #1690 slackbot.skills.library.remove
  7. feat: add admin.slackbot.skills.list method #1691 admin.slackbot.skills.list
  8. feat: add admin.slackbot.skills.publish method #1692 admin.slackbot.skills.publish
  9. feat: add admin.slackbot.skills.setAutoEnabled method #1693 admin.slackbot.skills.setAutoEnabled
  10. feat: add admin.slackbot.skills.unpublish method #1694 admin.slackbot.skills.unpublish
  11. feat: add slackbot.skills.delete method #1695 slackbot.skills.delete

Testing

Run the remote tests for this layer:

  • test_with_remote_apis.methods.slackbot_skills_Test with SLACK_SDK_TEST_BOT_TOKEN (canvases:write, skills:read, skills:write)

Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

zimeg and others added 3 commits November 11, 2026 22:41
Adds the slackbot.skills.create Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.info Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.update Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (5096ed0) to head (d2e802b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1687      +/-   ##
============================================
+ Coverage     73.79%   73.82%   +0.02%     
- Complexity     4690     4698       +8     
============================================
  Files           487      487              
  Lines         14692    14707      +15     
  Branches       1529     1530       +1     
============================================
+ Hits          10842    10857      +15     
- Misses         2939     2942       +3     
+ Partials        911      908       -3     
Flag Coverage Δ
jdk-14 73.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 5 commits November 11, 2026 23:09
Parses a live slackbot.skills.create response with unknown properties failing the test.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Parses a live slackbot.skills.info response with unknown properties failing the test.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Parses a live slackbot.skills.update response with unknown properties failing the test.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg marked this pull request as ready for review November 12, 2026 23:43
@zimeg
zimeg requested a review from a team as a code owner November 12, 2026 23:43
zimeg and others added 2 commits November 12, 2026 15:59
zimeg and others added 24 commits November 12, 2026 16:28
Matches the order on docs.slack.dev/reference/methods, the imports
(slack_lists before slackbot) and the generated rate_limit_tiers.json.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mcp_servers on slackbot.skills.create now takes the request's own
McpServer class with service_type, app_id and server_id, and the
separate SkillMcpServer model is removed. invalid_mcp_servers in the
response uses the same class.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mcp_servers on slackbot.skills.update now takes the request's own
McpServer class with service_type, app_id and server_id.
invalid_mcp_servers in the response uses the same class.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
SlackbotSkillsCreateRequest.McpServer replaces it.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
invalid_mcp_servers uses the response's own McpServer class instead of
importing the request's.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
invalid_mcp_servers uses the response's own McpServer class instead of
importing the request's.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
A new skill can briefly read as skill_not_found, so the remote test
keeps the 3 second wait from the create layer before calling info.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Local method tests are named for the top-level namespace, like ChatTest
for chat.scheduledMessages and CanvasesTest for canvases.access.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg, the form test that pins omitted, cleared, and declared mcp_servers is exactly the coverage update needs.

assertThat(omitted.size(), is(1));
assertThat(omitted.name(0), is("skill_id"));

FormBody cleared = RequestFormBuilder.toForm(SlackbotSkillsUpdateRequest.builder()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Having the omitted, cleared, and declared cases side by side makes the [] behaviour really clear.

Base automatically changed from zimeg-feat-slackbot-skills-info to main November 13, 2026 03:22
@zimeg

zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

Thank you @mwbrooks! 💛 So glad the omitted, cleared, and declared mcp_servers cases read clearly side by side. Merging now 🚢

@zimeg
zimeg merged commit 778ae31 into main Nov 13, 2026
7 checks passed
@zimeg
zimeg deleted the zimeg-feat-slackbot-skills-update branch November 13, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants