Repository navigation
feat: add slackbot.skills.info method - #1686
Conversation
Adds the slackbot.skills.create Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.info Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
============================================
- Coverage 73.79% 73.77% -0.02%
- Complexity 4687 4690 +3
============================================
Files 487 487
Lines 14684 14692 +8
Branches 1529 1529
============================================
+ Hits 10836 10839 +3
- Misses 2939 2943 +4
- Partials 909 910 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Parses a live slackbot.skills.create response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Parses a live slackbot.skills.info response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the order on docs.slack.dev/reference/methods, the imports (slack_lists before slackbot) and the generated rate_limit_tiers.json. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
mcp_servers on slackbot.skills.create now takes the request's own McpServer class with service_type, app_id and server_id, and the separate SkillMcpServer model is removed. invalid_mcp_servers in the response uses the same class. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
SlackbotSkillsCreateRequest.McpServer replaces it. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
invalid_mcp_servers uses the response's own McpServer class instead of importing the request's. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
| Thread.sleep(3000L); // A new skill can briefly read as skill_not_found | ||
|
|
||
| deleteSkill(client, botToken, skillId); | ||
| try { |
There was a problem hiding this comment.
suggestion (non-blocking): The removed sleep noted that a new skill can briefly read as skill_not_found, and this now calls info right after create. Could we keep a short wait here, like skills_canvas still does, so the remote run doesn't flake?
| try { | |
| Thread.sleep(3000L); // A new skill can briefly read as skill_not_found | |
| try { |
A new skill can briefly read as skill_not_found, so the remote test keeps the 3 second wait from the create layer before calling info. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Local method tests are named for the top-level namespace, like ChatTest for chat.scheduledMessages and CanvasesTest for canvases.access. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
Thanks again @mwbrooks! 🙏 Your catch on the missing wait before |
This pull request adds the
slackbot.skills.infomethod to the sync and async clients.slackbotSkillsInfotakesskillId.SlackbotTestparses a response captured from the live API with unknown properties failing the test, so every returned field is typed.This is part 2 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.
slackbot.skills.createslackbot.skills.info👈 this pull requestslackbot.skills.updateslackbot.skills.listslackbot.skills.library.addslackbot.skills.library.removeadmin.slackbot.skills.listadmin.slackbot.skills.publishadmin.slackbot.skills.setAutoEnabledadmin.slackbot.skills.unpublishslackbot.skills.deleteTesting
Run the remote tests for this layer:
test_with_remote_apis.methods.slackbot_skills_TestwithSLACK_SDK_TEST_BOT_TOKEN(canvases:write,skills:read,skills:write)Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code