Repository navigation
feat: add slackbot.skills.library.remove method - #1690
Merged
Merged
Conversation
Adds the slackbot.skills.create Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.info Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.update Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.list Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.library.add Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.library.remove Web API method to the sync and async clients, with its request and response types, mock fixture, rate limit tier, and tests. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This was referenced Nov 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
=========================================
Coverage 73.85% 73.85%
- Complexity 4706 4711 +5
=========================================
Files 487 487
Lines 14726 14734 +8
Branches 1530 1530
=========================================
+ Hits 10876 10882 +6
- Misses 2939 2943 +4
+ Partials 911 909 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
2 tasks done
Parses a live slackbot.skills.create response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Parses a live slackbot.skills.info response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Parses a live slackbot.skills.update response with unknown properties failing the test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ot-skills-library-add
…-slackbot-skills-library-remove
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig fails on unknown properties, and the inline JSON ends each line with \n. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ot-skills-library-add
…-slackbot-skills-library-remove
A new skill can briefly read as skill_not_found, so the remote test keeps the 3 second wait from the create layer before calling info. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ot-skills-library-add
…-slackbot-skills-library-remove
Local method tests are named for the top-level namespace, like ChatTest for chat.scheduledMessages and CanvasesTest for canvases.access. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ot-skills-library-add
…-slackbot-skills-library-remove
Base automatically changed from
zimeg-feat-slackbot-skills-library-add
to
main
November 13, 2026 03:54
Member
Author
|
Thanks @mwbrooks! 🙏 Really glad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
slackbot.skills.library.removemethod to the sync and async clients.slackbotSkillsLibraryRemovetakesskillId.This is part 6 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.
slackbot.skills.createslackbot.skills.infoslackbot.skills.updateslackbot.skills.listslackbot.skills.library.addslackbot.skills.library.remove👈 this pull requestadmin.slackbot.skills.listadmin.slackbot.skills.publishadmin.slackbot.skills.setAutoEnabledadmin.slackbot.skills.unpublishslackbot.skills.deleteTesting
Run the remote tests for this layer:
test_with_remote_apis.methods.slackbot_skills_TestwithSLACK_SDK_TEST_BOT_TOKEN(canvases:write,skills:read,skills:write)Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code