Skip to content

feat: add admin.slackbot.skills.unpublish method - #1694

Merged
zimeg merged 116 commits into
mainfrom
zimeg-feat-slackbot-skills-admin-unpublish
Nov 13, 2026
Merged

zimeg merged 116 commits into
mainfrom
zimeg-feat-slackbot-skills-admin-unpublish

Conversation

@zimeg

@zimeg zimeg commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

This pull request adds the admin.slackbot.skills.unpublish method to the sync and async clients.

  • adminSlackbotSkillsUnpublish takes skillIds.
  • skill_ids is sent comma-joined. A partial failure returns failed_for_some_skills with failed_skills.
  • SlackbotTest parses a response captured from the live API with unknown properties failing the test, so every returned field is typed.

This is part 10 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. It replaces #1683.

  1. feat: add slackbot.skills.create method #1685 slackbot.skills.create
  2. feat: add slackbot.skills.info method #1686 slackbot.skills.info
  3. feat: add slackbot.skills.update method #1687 slackbot.skills.update
  4. feat: add slackbot.skills.list method #1688 slackbot.skills.list
  5. feat: add slackbot.skills.library.add method #1689 slackbot.skills.library.add
  6. feat: add slackbot.skills.library.remove method #1690 slackbot.skills.library.remove
  7. feat: add admin.slackbot.skills.list method #1691 admin.slackbot.skills.list
  8. feat: add admin.slackbot.skills.publish method #1692 admin.slackbot.skills.publish
  9. feat: add admin.slackbot.skills.setAutoEnabled method #1693 admin.slackbot.skills.setAutoEnabled
  10. feat: add admin.slackbot.skills.unpublish method #1694 admin.slackbot.skills.unpublish 👈 this pull request
  11. feat: add slackbot.skills.delete method #1695 slackbot.skills.delete

Testing

Run the remote tests for this layer:

  • test_with_remote_apis.methods.slackbot_skills_Test with SLACK_SDK_TEST_BOT_TOKEN (canvases:write, skills:read, skills:write)
  • test_with_remote_apis.methods_admin_api.AdminApi_slackbot_skills_Test with SLACK_SDK_TEST_GRID_ORG_ADMIN_USER_TOKEN (admin.skills:read, admin.skills:write, skills:write)

Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. Test skills are deleted at the end.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

zimeg and others added 10 commits November 11, 2026 22:41
Adds the slackbot.skills.create Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.info Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.update Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.list Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.library.add Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the slackbot.skills.library.remove Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the admin.slackbot.skills.list Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the admin.slackbot.skills.publish Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the admin.slackbot.skills.setAutoEnabled Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Adds the admin.slackbot.skills.unpublish Web API method to the sync and async clients, with its
request and response types, mock fixture, rate limit tier, and tests.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.89%. Comparing base (e85f12c) to head (6957b11).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...java/com/slack/api/methods/RequestFormBuilder.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1694      +/-   ##
============================================
- Coverage     73.92%   73.89%   -0.04%     
- Complexity     4728     4730       +2     
============================================
  Files           487      487              
  Lines         14767    14775       +8     
  Branches       1533     1534       +1     
============================================
+ Hits          10917    10918       +1     
- Misses         2939     2944       +5     
- Partials        911      913       +2     
Flag Coverage Δ
jdk-14 73.89% <87.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 2 commits November 11, 2026 23:09
Parses a live slackbot.skills.create response with unknown properties failing the test.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg and others added 24 commits November 12, 2026 18:34
…ackTestConfig

Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…stConfig

Matches the OAuthTest and ConversationsTest pattern: SlackTestConfig
fails on unknown properties, and the inline JSON ends each line with \n.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
A new skill can briefly read as skill_not_found, so the remote test
keeps the 3 second wait from the create layer before calling info.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Local method tests are named for the top-level namespace, like ChatTest
for chat.scheduledMessages and CanvasesTest for canvases.access.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg, unpublish rounds out the admin side of the lifecycle neatly.

Base automatically changed from zimeg-feat-slackbot-skills-admin-set-auto-enabled to main November 13, 2026 04:34
@zimeg

zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

Thanks so much @mwbrooks! 🙏 Just one more layer to go after this. Merging now 🚢

@zimeg
zimeg merged commit e24c4cf into main Nov 13, 2026
7 checks passed
@zimeg
zimeg deleted the zimeg-feat-slackbot-skills-admin-unpublish branch November 13, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants