Repository navigation
Add typed JSON output to theme profile - #8643
Open
gonzaloriestra wants to merge 4 commits into
Open
gonzaloriestra wants to merge 4 commits into
gonzaloriestra wants to merge 4 commits into
Conversation
gonzaloriestra
added this pull request to stack #8644
September 24, 2026 09:19
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 24, 2026 10:04
964fa3f to
31cc224
Compare
gonzaloriestra
removed this pull request from stack #8644
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 24, 2026 10:11
31cc224 to
0473c3d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
2 times, most recently
from
September 24, 2026 10:21
42d0894 to
b52a551
Compare
This was referenced Sep 24, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 24, 2026 10:25
b52a551 to
fffea1c
Compare
3 of 4 tasks
This was referenced Sep 24, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 24, 2026 11:56
fffea1c to
0c0d218
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 24, 2026 13:46
0c0d218 to
2139045
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 29, 2026 11:11
a5c8e13 to
61b111d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
September 29, 2026 11:38
61b111d to
8a2dfe7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
2 times, most recently
from
September 29, 2026 14:18
00c153b to
5ad8644
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
2 times, most recently
from
October 1, 2026 08:52
7542d09 to
a8cef4b
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 6, 2026 12:29
a8cef4b to
ca2cebe
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 6, 2026 12:31
ca2cebe to
ba654bb
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 6, 2026 13:53
ba654bb to
8c90a39
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 6, 2026 13:56
8c90a39 to
655353a
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Explicit theme profiling environments need the same ordered batch contract.
WHAT is this pull request doing?
Preserve the native Speedscope artifact and wrap explicitly named environments in one result object. Separate service data from presentation and keep failures on the shared fatal path.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add